Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Record coverage in subprocesses as well #2556

Merged
merged 11 commits into from
Dec 25, 2024

Conversation

stefan6419846
Copy link
Collaborator

No description provided.

@stefan6419846 stefan6419846 added the nf-ci Non-functional change: Continuous Integration label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (6d4e2ec) to head (ada38ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          52       52           
  Lines        8767     8767           
  Branches     1595     1595           
=======================================
  Hits         8449     8449           
  Misses        190      190           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator Author

Somehow GitHub does not seem to pick up the configuration - running COVERAGE_PROCESS_START=pyproject.toml python -m pytest tests --cov=pypdf --cov-append -n auto -vv locally does indeed show a difference.

@stefan6419846
Copy link
Collaborator Author

Assumption: We need to use more recent versions of some dependencies to fix this as the latest version would work this way locally and in another project of mine.

@pubpub-zz
Copy link
Collaborator

do you have any ideas of which modules needs to be updated and to which minimum version?

@stefan6419846
Copy link
Collaborator Author

Most likely coverage.py and/or pytest-cov, but I have not yet verified this.

@pubpub-zz pubpub-zz marked this pull request as draft June 7, 2024 20:46
@stefan6419846 stefan6419846 marked this pull request as ready for review November 3, 2024 16:50
@pubpub-zz
Copy link
Collaborator

is this ready for review ?

@stefan6419846
Copy link
Collaborator Author

Yes, this should be ready.

@pubpub-zz pubpub-zz merged commit ddc23bb into py-pdf:main Dec 25, 2024
16 checks passed
@stefan6419846 stefan6419846 deleted the subprocess-coverage branch December 25, 2024 11:11
@pubpub-zz
Copy link
Collaborator

For information : a failed worker error raised, needing rerun. the message was very obvious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-ci Non-functional change: Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants