Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix label parsing #193

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix: fix label parsing #193

merged 1 commit into from
Jul 13, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jul 13, 2024

closes #192

Right now i was trying to pull all issues which meant it was grabbing issues that were NOT actually review issues. I decided it was better to be explicit. This pr thus fixes two things

  1. it allows us to parse through issues and look for issues that contain a specific label. By default the rest endpoint returns issues with ALL labels included. But we wanted the select an issue based upon a specific label occuring within a set of labels. This implements that by filtering issues. GraphQL i think has an OR option? but i just am trying to get the peer-review-metrics running again with this pr.
  2. This pr also adds an alias for repo_link to support the presubmission template

@lwasser
Copy link
Member Author

lwasser commented Jul 13, 2024

I am merging and creating a release quickly to see if i can fix the build before our sprints tomorrow!

@lwasser lwasser merged commit 2996a34 into pyOpenSci:main Jul 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug / feature] : challenges pulling all review issues from our pyos meta package
1 participant