Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add members to ParamSpec stub #2371

Merged

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes pylint-dev/pylint#9401

More substantive fix to prevent issues like this in the future described at #2370.

DanielNoord
DanielNoord previously approved these changes Feb 3, 2024
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ParamSpec is new in 3.10
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a82d9d9) 92.86% compared to head (7c877ae) 92.85%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   92.86%   92.85%   -0.01%     
==========================================
  Files          94       94              
  Lines       11072    11071       -1     
==========================================
- Hits        10282    10280       -2     
- Misses        790      791       +1     
Flag Coverage Δ
linux 92.66% <ø> (-0.01%) ⬇️
pypy 90.99% <ø> (-0.01%) ⬇️
windows 92.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/brain/brain_typing.py 87.17% <ø> (ø)

... and 10 files with indirect coverage changes

@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) February 3, 2024 23:51
@jacobtylerwalls jacobtylerwalls merged commit 32bbc02 into pylint-dev:main Feb 4, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
(cherry picked from commit 32bbc02)
Pierre-Sassoulas pushed a commit that referenced this pull request Feb 4, 2024
(cherry picked from commit 32bbc02)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the add-paramspec-members branch February 4, 2024 12:55
@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/3.3.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Bug 🪳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive: no-member for ParamSpec under Python 3.12
3 participants