-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add members to ParamSpec
stub
#2371
Merged
jacobtylerwalls
merged 3 commits into
pylint-dev:main
from
jacobtylerwalls:add-paramspec-members
Feb 4, 2024
Merged
Add members to ParamSpec
stub
#2371
jacobtylerwalls
merged 3 commits into
pylint-dev:main
from
jacobtylerwalls:add-paramspec-members
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
previously approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ParamSpec is new in 3.10
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
- Coverage 92.86% 92.85% -0.01%
==========================================
Files 94 94
Lines 11072 11071 -1
==========================================
- Hits 10282 10280 -2
- Misses 790 791 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
approved these changes
Feb 4, 2024
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 4, 2024
Pierre-Sassoulas
added
backported
Assigned once the backport is done
and removed
backport maintenance/3.3.x
labels
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes pylint-dev/pylint#9401
More substantive fix to prevent issues like this in the future described at #2370.