Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use instance's default queue for queued_jobs default #368

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

phy1729
Copy link
Contributor

@phy1729 phy1729 commented Dec 4, 2022

I think it would be less surprising for queued_jobs to default to the instance's default rather than the global default.

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #368 (7c8d048) into main (b6dda0e) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   98.74%   98.64%   -0.11%     
==========================================
  Files           9        9              
  Lines         957      959       +2     
  Branches      179      180       +1     
==========================================
+ Hits          945      946       +1     
  Misses          6        6              
- Partials        6        7       +1     
Impacted Files Coverage Δ
arq/connections.py 95.20% <66.66%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dda0e...7c8d048. Read the comment docs.

arq/connections.py Show resolved Hide resolved
Copy link
Collaborator

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry about my tired eyes causing the confusion 😁

@samuelcolvin samuelcolvin merged commit bfa8e68 into python-arq:main Dec 14, 2022
@phy1729 phy1729 deleted the queued_jobs-default branch May 20, 2023 23:17
@samuelcolvin
Copy link
Member

v0.26.0b1 is released, please try it, I'll release v0.26 at the end of the week, see #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants