perf: let Transaction.calculate_operations run in O(N) #8063
+55
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
perf/transaction-dict
branch
from
22b36eb to
b01d3a2
Compare
radoering
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Rebased on current main with some minor adaptions:
I only adopted the change for _installed_packages because that is the only list without duplicate package names. Building a dict of _current_packages and _result_packages is dangerous because it drops distinct entries with the same name. Further, there is no need for a dict for _current_packages and (with changes on the main branch, which happened in the meantime) there is no need for a dict for _result_packages anymore.
I agree that making _installed_packages a dict improves maintainability.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard to call it a
perfcommit, as we are talking about a few milliseconds, but I think it also makes the code more Pythonic