Add shadowing warning to supplemental source docs #8733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for website ready! ✅ Preview Built with commit b810729. |
radoering
reviewed
Dec 4, 2023
radoering
approved these changes
Dec 4, 2023
MrGreenTea
pushed a commit
to MrGreenTea/poetry
that referenced
this pull request
Dec 18, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want people to consider what happens if someone publishes a new package to PyPI which matches one in their supplemental source. There were a few dependency confusion vulnerabilities a while back that were caused by something similar. I presume lock files help to some extent though.
Pull Request Check List
Resolves: None