gh-88834: Unify the instance check for typing.Union and types.UnionType #128363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nionType Union now uses the instance checks against its parameters instead of the subclass checks.
serhiy-storchaka
requested review from
JelleZijlstra and
AlexWaygood
as code owners
serhiy-storchaka
added
needs backport to 3.12
JelleZijlstra
approved these changes
Dec 30, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 31, 2024
…nionType (pythonGH-128363) Union now uses the instance checks against its parameters instead of the subclass checks. (cherry picked from commit b2ac70a62ad1be8e037ce45ccf5f1b753ea5e64b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 31, 2024
…nionType (pythonGH-128363) Union now uses the instance checks against its parameters instead of the subclass checks. (cherry picked from commit b2ac70a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-128370 is a backport of this pull request to the 3.13 branch. |
|
GH-128371 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 31, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union now uses the instance checks against its parameters instead of the subclass checks.