Injected becomes a separate package #9

qzmech · 2023-05-15T00:40:45Z

Hello Team!

Injected has been redesigned to become a separate PyPi package.

Check out the following changes:

Added cmake assembly for 32 and 64-bit platforms.
Added copying DLLs to package root before creating PyPi wheel.
Package name for PyPi: injectdll
Redesigned code to meet PEP requirements
New README (draft)
License text updated

Changes: 1) Created a new "injectdll" package 2) Formatted all *.py modules from the package 3) Refactoring CMakeLists.txt (fixed some paths to source files) 4) Created setup.py to generate Wheel on local computer (includes: build cmake for DLL (dotnet, hooks), copy to package directory after build) 5) Fixed license text

Changes: 1) New README 2) Cmake build for 32 and 64-bit platform

backends/dotnet/CMakeLists.txt

backends/hook/CMakeLists.txt

injectdll/api.py

vasily-v-ryabov · 2023-05-17T14:34:12Z

setup.py

+      description='A set of Python modules to inject DLls into applications for the Microsoft Windows',
+      keywords="windows gui .net inject testing test desktop dll wpf",
+      url="https://github.com/pywinauto/injected",
+      author='Mark Mc Mahon and Contributors',


Mark didn't participate in injectdll development, but I need to carefully review the code one more time to check if there is some code written by him a long time ago.

It's for file headers. Of course author field should omit (C) and years.

vasily-v-ryabov · 2023-05-24T09:43:40Z

injectdll/injector.py

            raise RuntimeError("Application and Python must be both 32-bit or both 64-bit")
        self.h_process = self._get_process_handle(self.pid)

        self.dll_path = os.path.join(os.path.dirname(os.path.realpath(__file__)),
-                                     'backends', backend_name,
-                                     'bin', 'x{}'.format("64" if is64bitprocess(self.pid) else "86"),
+                                     '../libs', backend_name,


It's better to use os.path.dirname(...) than using ../ which may be platform specific.

Ok, will be fixed in next commits

vasily-v-ryabov · 2023-05-24T10:08:33Z

README.md

+## Development
+
+ 1. Clone repository: <https://github.com/pywinauto/injected.git>
+ 2. Create new features or improve exiting (for the injectdll package)


typo: exiting -> existing, but I would completely remove all "Development" steps or write "Issues and pull requests are welcome!"

Ok, will be fixed in next commits

vasily-v-ryabov · 2023-05-24T10:13:36Z

setup.py

+      author='Mark Mc Mahon and Contributors',
+      author_email='pywinauto@yandex.ru',
+      long_description="""
+It allows to inject DLls into applications for the Microsoft Windows.


DLls -> DLLs, or even suggest this:

This package can inject pre-built dynamic library into the target process and get some data from the application or do some actions (it depends on a used backend/library).

Ok, will be fixed in next commits

eltimen · 2023-05-28T16:55:22Z

README.md

+
+## How to use
+
+    python.exe example_injector.py \<Process name\> \<path to dll\> 


The script example_injector.py was removed

eltimen · 2023-05-28T17:05:38Z

MANIFEST.in

@@ -0,0 +1,14 @@
+include injectdll/libs/dotnet/x86/bootstrap.dll


You can also remove *.dll files in this folder: https://github.com/pywinauto/injected/tree/master/backends/dotnet/bin
These files will not be needed after the injectdll wheels is available.

Ok, It will be removed.

I'm not sure about this point. Is this manifest not used for building wheels by setup.py?

This manifest is OK, I meant that the pre-built DLLs in the bin folders will no longer be needed after merging this PR and having wheels.

eltimen · 2023-05-28T17:17:15Z

backends/dotnet/src/wpf/CMakeLists.txt

@@ -9,7 +9,7 @@ elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
 	set(CMAKE_CSharp_FLAGS "/platform:x86")
 endif()

-set(CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION "v4.0")
+set(CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION "v4.8")


Why did you increase the target .NET version?
In this case a subset of programs built with .NET Framework versions 4.0-4.8 will not be supported by this backend.

While debugging, I couldn't use .NET Target Framework v4.0 (I already have v 4.8. and .NET doesn't let me roll back the Framework version).
It will be fixed in the next commits.

eltimen · 2023-05-28T17:24:04Z

injectdll/api.py

+        return self._pipes[pid]
+
+    def _create_pipe(self, pid):
+        pipe_name = 'process_{}'.format(pid)


If you want to change the name of pipe, you also need to change it on the backend side here:

injected/backends/dotnet/src/wpf/Main.cs

Line 16 in a7eee0e

using (NamedPipeServerStream pipeServer = new NamedPipeServerStream(String.Format("pywinauto_{0}", pid), PipeDirection.InOut, 1, PipeTransmissionMode.Message))

Note: prefix pywinauto_ looks better for me, because it is less ambiguous and avoids possible conflicts with other applications (for example, some other process may want to create pipe with name process_{PID})

@vasily-v-ryabov suggested removing all mention of the pywinauto project.
Maybe I should use injectdll_ instead, what do you think?

As I remember, I suggested using 2 PIDs in a pipe name: Python process and target process. Also I'd suggest adding a text param for the part of the name. For example, pywinauto will name this pipe "pywinauto_{py_pid}_{target_pid}", other lib or app can assign another text part of the name. It should make the pipe name 100% unique.

The most important thing is to specify the same pipe name on the client and server sides, otherwise this code will not work :)

eltimen · 2023-05-28T17:30:07Z

injectdll/api.py

+        reply = json.loads(reply)
+
+        reply_code = reply['status_code']
+        reply_message = reply['message']


The message is optional field of JSON reply, so this code can raise a KeyError

It will be fixed in the next commits.

eltimen · 2023-05-28T17:47:45Z

setup.py

+        subprocess.check_call(['cmake', '-B ' + build_dir, '-S ' + cmake_dir, '-A ' + arch])
+        subprocess.check_call(['cmake', '--build', build_dir])


CMake build DLLs in Debug mode here. I think it will be better to build it in Release (or RelWithDebInfo?) mode.

It will be fixed in the next commits.

qzmech added 3 commits May 12, 2023 13:04

Delete __init__.py from project root

1f1321d

Added build for 32 and 64-bit platform and new README

e77710b

Changes: 1) New README 2) Cmake build for 32 and 64-bit platform

qzmech requested a review from vasily-v-ryabov May 15, 2023 00:40

vasily-v-ryabov reviewed May 17, 2023

View reviewed changes

qzmech added 5 commits May 17, 2023 20:26

Fixed to match code style

901f10e

Update README.md

332702e

Update README.md

19e6ad4

Fixed to match code style 2

f414e2a

Update README.md

c039cc4

vasily-v-ryabov reviewed May 24, 2023

View reviewed changes

eltimen reviewed May 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Injected becomes a separate package #9

Injected becomes a separate package #9

qzmech commented May 15, 2023

vasily-v-ryabov May 17, 2023

qzmech May 24, 2023

vasily-v-ryabov May 24, 2023

vasily-v-ryabov May 24, 2023

qzmech May 24, 2023

vasily-v-ryabov May 24, 2023

qzmech May 24, 2023

vasily-v-ryabov May 24, 2023

qzmech May 24, 2023

eltimen May 28, 2023

eltimen May 28, 2023

qzmech May 28, 2023

vasily-v-ryabov May 29, 2023

eltimen May 29, 2023 •

edited

Loading

eltimen May 28, 2023

qzmech May 28, 2023

eltimen May 28, 2023 •

edited

Loading

qzmech May 28, 2023

vasily-v-ryabov May 29, 2023

eltimen May 29, 2023

eltimen May 28, 2023

qzmech May 28, 2023

eltimen May 28, 2023 •

edited

Loading

qzmech May 28, 2023


		## How to use

		python.exe example_injector.py \<Process name\> \<path to dll\>

		@@ -0,0 +1,14 @@
		include injectdll/libs/dotnet/x86/bootstrap.dll

		subprocess.check_call(['cmake', '-B ' + build_dir, '-S ' + cmake_dir, '-A ' + arch])
		subprocess.check_call(['cmake', '--build', build_dir])

Injected becomes a separate package #9

Are you sure you want to change the base?

Injected becomes a separate package #9

Conversation

qzmech commented May 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eltimen May 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eltimen May 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eltimen May 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eltimen May 29, 2023 •

edited

Loading

eltimen May 28, 2023 •

edited

Loading

eltimen May 28, 2023 •

edited

Loading