Merge pull request #4 from jafuentest/master

Remove missing elements from scroll info
qbatch · Jun 13, 2018 · e6bb55b · e6bb55b
2 parents d50d179 + 511b171
commit e6bb55b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/heatmap/rails/helper.rb b/lib/heatmap/rails/helper.rb
@@ -238,8 +238,11 @@ def show_heatmap(path,type = false)
   heatmapInstance.addData(data_xpath);
   var scroll = JSON.parse('#{raw(@scroll_data.to_json.html_safe)}');
   var scroll_data = scroll.map(function(element){
-    width = getElement(element.xpath).getBoundingClientRect().width;
-    height = getElement(element.xpath).getBoundingClientRect().height;
+    var element = getElement(element.xpath);
+    if (!element)
+      return;
+    width = element.getBoundingClientRect().width;
+    height = element.getBoundingClientRect().height;
     dot = document.createElement('div');
     dot.className = "dot";
     dot.style.left = (getOffset(element.xpath).x+  (width * element.offset_x)) + "px";
@@ -261,6 +264,7 @@ def show_heatmap(path,type = false)
     document.body.appendChild(dot);
   });
 
+  scroll_data = scroll_data.filter(function(val){ return val!==undefined; });
 </script>
 JS