-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto: move profiles rules filter to generic class and use it systematically in jobs #487
Refacto: move profiles rules filter to generic class and use it systematically in jobs #487
Conversation
d830b92
to
a3dcb5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 70.64% 70.19% -0.46%
==========================================
Files 48 48
Lines 3015 3013 -2
Branches 648 648
==========================================
- Hits 2130 2115 -15
- Misses 701 710 +9
- Partials 184 188 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8a4dfb0
to
a0d5af7
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
This PR is a following up of #481 and #486.
After some real-life testing of the profile deployment rules, it became clear that the initial implementation was clumsy.
By placing the filtering of profiles based on rules in the qprofiles-synchronizer job alone, we forget that other jobs based on the content of downloaded profiles also need to respect the rules: qplugins-synchronizer, etc.
This PR fixes this by moving the rules filtering logic
right into the generic job class and make sure that every job which relies on downloaded profiles use the same method to filter on rules.