Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): make sure dl_url is a string #594

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(test): make sure dl_url is a string #594

merged 1 commit into from
Dec 3, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Dec 3, 2024

@github-actions github-actions bot added bug Something isn't working quality Tests, project resiliency, etc. labels Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files          47       47           
  Lines        3188     3188           
  Branches      558      558           
=======================================
  Hits         2243     2243           
  Misses        747      747           
  Partials      198      198           
Flag Coverage Δ
unittests 69.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Guts Guts requested a review from jmkerloch December 3, 2024 15:16
@Guts Guts self-assigned this Dec 3, 2024
Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Guts Guts merged commit 59a5ef1 into main Dec 3, 2024
25 checks passed
@Guts Guts deleted the fix/upgrade-test branch December 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants