Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schemas #600

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix schemas #600

merged 2 commits into from
Dec 13, 2024

Conversation

nicogodet
Copy link
Contributor

Few fixes for profile and scenario schema

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Dec 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nicogodet
Copy link
Contributor Author

I used https://www.jsonschemavalidator.net/

@Guts
Copy link
Collaborator

Guts commented Dec 13, 2024

I used https://www.jsonschemavalidator.net/

Can you share the URL with the saved params?

Guts
Guts approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to see a new contributor so, even if I've made differnte changes, since it's not on a critical side of the project, I think we can merge this one and see later to improve it if needed.

@Guts
Copy link
Collaborator

Guts commented Dec 13, 2024

Welcome to QDT contributors @nicogodet 🍻

@Guts Guts merged commit a96826b into qgis-deployment:main Dec 13, 2024
5 checks passed
This was referenced Dec 13, 2024
Merged
Closed
@Guts Guts linked an issue Dec 13, 2024 that may be closed by this pull request
[BUG]: TypeError: Options to validate must be a dict, not <class 'list'> #599
Closed
1 task
Guts added a commit that referenced this pull request Dec 13, 2024
@Guts
fix(docs): simplify JSON schema of job qgis-finder (#601)
cb99e2f 
Following up of #600 

Before:

> after PR #600



![](https://pad.oslandia.net/uploads/4e445daa-2e84-40f1-9573-ce24882dd97d.png)

- the schema does not matches structure, so validation is not really
working
- it's "visible" with missing tooltip when over on keywords


After this PR:


![](https://pad.oslandia.net/uploads/f2e76dd1-69f7-4a54-b5c2-956589df80eb.png)

See visible tooltips when mouse hover
@nicogodet
Copy link
Contributor Author

I used https://www.jsonschemavalidator.net/

Can you share the URL with the saved params?

I forget to save it unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: TypeError: Options to validate must be a dict, not <class 'list'>
2 participants
@nicogodet @Guts