Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskit-ibm-provider support #1493

Closed
wants to merge 3 commits into from

Conversation

1ucian0
Copy link
Contributor

@1ucian0 1ucian0 commented Nov 18, 2024

Summary

qiskit-ibm-provider does not have support since Jul 2024. Time to clean its handling?

Details and comments

I tried to find all the places and branches that handle qiskit-ibm-provider cases. Not sure if I found all of them.

PR checklist (delete when all criteria are met)

  • I have read the contributing guide CONTRIBUTING.md.
  • I have added a release note file using reno if this change needs to be documented in the release notes.

@1ucian0 1ucian0 changed the title Remove ibm provider/1 Remove qiskit-ibm-provider support Nov 18, 2024
@wshanks
Copy link
Collaborator

wshanks commented Nov 18, 2024

Thanks for looking into this @1ucian0. As far as I can tell, the retrieve_job usage is safe to remove. With the other usage, I think we need to update the code a bit more. If we take qiskit-ibm-runtime as the primary target interface (trying to avoid calling it a "provider" to avoid confusion), then what the code calls a "provider" should now be QiskitRuntimeService instead of IBMProvider. So think we could keep some of the things you remove here if we change to look for service instead of provider. Confusingly, the code refers to the class for gettings jobs/backends as the provider and the experiments service as service but now qiskit-ibm-runtime calls the provider-like thing service as well, so there are two services to track.

@wshanks
Copy link
Collaborator

wshanks commented Dec 27, 2024

Thanks, @1ucian0! I incorporated changes to the parts of the code you highlighted here into #1502.

@wshanks wshanks closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants