Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python-based PDD solver option and fix sign convention inconsistencies #265

Merged
merged 27 commits into from
Nov 19, 2023

Further Sesame changes

692c986
Select commit
Loading
Failed to load commit list.
Merged

Add Python-based PDD solver option and fix sign convention inconsistencies #265

Further Sesame changes
692c986
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2023 in 1s

59.47% (+2.22%) compared to 31d9110

View this Pull Request on Codecov

59.47% (+2.22%) compared to 31d9110

Details

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (31d9110) 57.25% compared to head (692c986) 59.47%.

Files Patch % Lines
solcore/sesame_drift_diffusion/solve_pdd.py 93.10% 10 Missing ⚠️
solcore/solar_cell_solver.py 45.45% 6 Missing ⚠️
...olcore/sesame_drift_diffusion/process_structure.py 98.32% 3 Missing ⚠️
...re/analytic_solar_cells/depletion_approximation.py 84.61% 2 Missing ⚠️
solcore/material_data/mobility.py 0.00% 1 Missing ⚠️
...poisson_drift_diffusion/DriftDiffusionUtilities.py 85.71% 1 Missing ⚠️
solcore/poisson_drift_diffusion/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #265      +/-   ##
===========================================
+ Coverage    57.25%   59.47%   +2.22%     
===========================================
  Files          104      108       +4     
  Lines        11690    12341     +651     
===========================================
+ Hits          6693     7340     +647     
- Misses        4997     5001       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov