-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external mixer support to QuAM. #271
Conversation
deanpoulos
commented
Dec 19, 2024
- Requires py-qua-tools branch to work
- Generates a state.json no problem
- Haven't tested any experiments/simulation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, I had one comment but no strong opinions on it
Quantum-Control-Applications-QuAM/Superconducting/quam_libs/quam_builder/machine.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qua-libs> & C:/Users/KevinAVillegasRosale/anaconda3/envs/qolab_qm/python.exe "c:/Users/KevinAVillegasRosale/OneDrive - QM Machines LTD/Documents/GitKraken/qua-libs/Quantum-Control-Applications-QuAM/Superconducting/configuration/make_wiring_opxp_external_mixers.py"
2024-12-19 14:47:09,957 - qm - INFO - Starting session: 43eef3d2-49e9-4b6d-a595-aa12b8468773
Traceback (most recent call last):
File "c:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qua-libs\Quantum-Control-Applications-QuAM\Superconducting\configuration\make_wiring_opxp_external_mixers.py", line 44, in
build_quam_wiring(connectivity, host_ip, cluster_name, path)
build_quam_wiring(connectivity, host_ip, cluster_name, path)
File "C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qolab_hackathon\quam_libs\quam_builder\machine.py", line 39, in build_quam_wiring
build_quam_wiring(connectivity, host_ip, cluster_name, path)
build_quam_wiring(connectivity, host_ip, cluster_name, path)
File "C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qolab_hackathon\quam_libs\quam_builder\machine.py", line 39, in build_quam_wiring
machine.wiring = create_wiring(connectivity)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qolab_hackathon\quam_libs\quam_builder\wiring\create_wiring.py", line 23, in create_wiring
for k, v in qubit_wiring(channels).items():
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qolab_hackathon\quam_libs\quam_builder\wiring\create_wiring.py", line 44, in qubit_wiring
key, reference = get_channel_port(channel, channels)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\KevinAVillegasRosale\OneDrive - QM Machines LTD\Documents\GitKraken\qolab_hackathon\quam_libs\quam_builder\wiring\create_wiring.py", line 78, in get_channel_port
raise ValueError(f"Unknown instrument type {channel.instrument_id}")
ValueError: Unknown instrument type external-mixer
…orm/qua-libs into feature/SCquam_external_mixers