Add Azure Key Vault Extension #218
Conversation
…ension requires real service for testing.
| String dir = "QMETA-INF/services"; | ||
| String hotspotLibName = "jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory"; |
There was a problem hiding this comment.
Add a comment explaining what the QMETA-INF/services thing is.
| .filter(n -> n.startsWith("com.azure.security.keyvault.secrets.models.")) | ||
| .sorted() |
There was a problem hiding this comment.
By loading the classes in this way, we are creating an implicit contract: All of the classes that start with this package are "safe" to load in this way. Do we know this will always be true?
There was a problem hiding this comment.
The safest approach is to load the exact classes, see 5fce42c.
| .filter(s -> s.startsWith("com.azure.security.keyvault.secrets.implementation.models.")) | ||
| .forEach(e -> { |
There was a problem hiding this comment.
This is safe to use a startsWith approach here because we are pre-filtering with the getAllKnownImplementors.
integration-tests/README.md
Outdated
| ### Creating Azure Key Vault | ||
|
|
||
| Run the following commands to create an Azure Key Vault, set permission and export its connection string as an environment | ||
| variable. | ||
|
|
There was a problem hiding this comment.
Mention that the steps listed here are also performed by the GitHub Actions workflows via the build-with-native.sh file.
There was a problem hiding this comment.
Good catch, see 5fce42c.
| az keyvault create \ | ||
| --name ${KEY_VAULT_NAME} \ | ||
| --resource-group ${RESOURCE_GROUP_NAME} \ | ||
| --location eastus |
There was a problem hiding this comment.
Mention this duplicates code in integration-tests/README.md.
| ``` | ||
| KEY_VAULT_NAME=<unique-key-vault-name> | ||
| az keyvault create --name ${KEY_VAULT_NAME} \ | ||
| --resource-group ${RESOURCE_GROUP_NAME} \ | ||
| --location eastus |
There was a problem hiding this comment.
Mention the GitHub Actions workflow.
|
LGTM now, approved. |
This PR is related to #63, including:
SecretClientandSecretAsyncClientbean with propertyquarkus.azure.keyvault.secret.endpoint.Test: https://github.com/galiacheng/quarkus-azure-services/actions/runs/8829692524