Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonblob: Support individual record iteration #1334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvdm
Copy link
Contributor

@jvdm jvdm commented May 3, 2024

Add a per-record iterator interface using rangefunc-style to jsonblob. This conveniently aligns jsonblob to be used with the Vulnerability and Enrichment datastore iterator interfaces.

Signed-off-by: J. Victor Martins <jvdm@sdf.org>
@jvdm jvdm requested a review from a team as a code owner May 3, 2024 19:25
@jvdm jvdm requested review from hdonnay and removed request for a team May 3, 2024 19:25
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 55.82%. Comparing base (0831b93) to head (ef03423).

Files Patch % Lines
libvuln/jsonblob/jsonblob.go 78.57% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
+ Coverage   55.76%   55.82%   +0.06%     
==========================================
  Files         266      266              
  Lines       16759    16801      +42     
==========================================
+ Hits         9345     9379      +34     
- Misses       6445     6448       +3     
- Partials      969      974       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvdm jvdm changed the title jsonblob: Support iteration with rangefunc style jsonblob: Support individual record iteration May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant