-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab: use /oauth/userinfo and respect GITLAB_URL #129
base: master
Are you sure you want to change the base?
Conversation
@smancke it would be so great if you could find a moment to review and merge this to master in the nearest future. |
@smancke bumping request above ^ |
definitely need this |
Test failure is unrelated. amd64 build of caddy is located here: https://gitlab.com/gartnera/caddy-gitlab-login/-/jobs |
Hello @gartnera, |
Well, it looks like COVID-19 will eventually finish our living in misery faster than you making decision about merging this PR. Bumping... |
Gitlab supports the standard
/oauth/userinfo
oauth/odic endpoint so we should use that instead of gitlab specific API calls.Also allow setting the gitlab url via environment variable. Still defaults to https://gitlab.com.
Also set
DefaultScopes
correctly. Users should be instructed to grant their gitlab app to grant the following scopes:email openid
Closes #118