bugfix filter_stop_times: catch NAs for missing max_arrival_time

r-transit · Dec 20, 2024 · ad5e49d · ad5e49d
1 parent a09a52d
commit ad5e49d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/R/travel_times.R b/R/travel_times.R
@@ -214,7 +214,7 @@ filter_stop_times = function(gtfs_obj,
     min_departure_time <- hhmmss_to_seconds(min_departure_time)
   }
   if(missing(max_arrival_time)) {
-    max_arrival_time <- max(gtfs_obj$stop_times$arrival_time)+1
+    max_arrival_time <- max(gtfs_obj$stop_times$arrival_time, na.rm = TRUE)+1
   } else if(is.character(max_arrival_time)) {
     max_arrival_time <- hhmmss_to_seconds(max_arrival_time)
   }

diff --git a/tests/testthat/test-travel_times.R b/tests/testthat/test-travel_times.R
@@ -120,6 +120,7 @@ test_that("travel_times with filtered feed", {
 })
 
 test_that("time_range param", {
+  expect_is(filter_feed_by_date(gtfs_duke, "2019-10-01"), "tidygtfs")
   st = filter_feed_by_date(gtfs_routing, "2018-10-01")
 
   tt1 = travel_times(st, stop_name = "One", time_range = c("07:09:00", "07:59:00"))