Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos github action runner images ##build #23819

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jjaareet
Copy link
Contributor

@jjaareet jjaareet commented Dec 19, 2024

  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the book (optional)

Description

update macos github action runner images. probably not critical but ive been watching this project for a little while and keep seeing these failures

The macOS-12 environment is deprecated, consider switching to macOS-13, macOS-14 (macos-latest) or macOS-15. For more details, see actions/runner-images#10721

example failures:

example successes:

macos-test errors

https://github.com/jjaareet/radare2/actions/runs/12419539942/job/34675076320

Run pip3 install r2pipe; make tests
...
test_get_glibc_version OK
bin/test_get_main_arena_offset
ERROR: reloc conversion failed for 0x3c3d80
ERROR: reloc conversion failed for 0x3c3d80
INFO: Found main_arena with symbol
ERROR: reloc conversion failed for 0x3d9d60
ERROR: reloc conversion failed for 0x3d9d60
INFO: Found main_arena with symbol
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
WARN: Found main_arena offset with relocations
test_get_main_arena_offset_with_symbol OK
...
test_va_malloc_zero OK
bin/test_json
ERROR: no closing quote for string (unterminated string)
ERROR: unexpected chars ()
test_json (1) OK
ERROR: no closing quote for string (unterminated \string" ]
test_json (2) OK
...
test_json (7) OK
ERROR: unexpected end of text ()
ERROR: unexpected end of text ()
ERROR: unexpected chars ()
ERROR: unexpected chars ()
ERROR: invalid number (100000000000000000000000000000, -100000000000000000000000000000, "end" ]
)
ERROR: unexpected chars (ture,
 "who says JSON is easy for humans to generate?"]
)
ERROR: invalid number (- 
]

)
ERROR: unexpected chars (}
)
ERROR: endless comment (/*)
ERROR: endless comment (/*abc /)
ERROR: endless comment (/*/ 123)
ERROR: invalid unicode surrogate (\ud800"
)
ERROR: invalid unicode escape (\u04FG")
ERROR: invalid unicode escape (\u0)
ERROR: invalid unicode escape (\u04")
ERROR: unexpected chars (,}
)
ERROR: unexpected chars (,]
)
ERROR: unexpected chars ({}]
)
ERROR: unexpected chars (,1337]
)
ERROR: unexpected chars (,"invalid":123}
)
test_json (8) OK
...
test_pdb_type_save OK
ERROR: return code 127 for rodoro2 -N -q0 -
bin/test_pj
ERROR: [+] r2pipe link error
test_pj_reset OK
...
test_r_rbtree_augmented_insert_delete2 OK
bin/test_reg
ERROR: =A0 is not defined
ERROR: =A0 is not defined
ERROR: =A0 is not defined
ERROR: =A0 is not defined
ERROR: =A0 is not defined
ERROR: =A0 is not defined
test_r_reg_set_name OK
...
test_pvector_lower_bound OK
make[3]: *** [run] Error 1
make[2]: *** [unit-tests] Error 2
make[1]: *** [r2r-tests] Error 2
make: *** [tests] Error 2
unit1
Error: Process completed with exit code 2.

@trufae trufae merged commit d887d8b into radareorg:master Dec 19, 2024
43 checks passed
@trufae
Copy link
Collaborator

trufae commented Dec 19, 2024

Thanks for taking care :)

@jjaareet
Copy link
Contributor Author

thanks for the quick review and merge! here is the last time the macos-tests passed on master if it helps at all to fix the failing tests: #23719

https://github.com/radareorg/radare2/actions/runs/12118096223/job/33781904171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants