Fixes github#824

rak3-sh · Dec 17, 2024 · 3342bb5 · 3342bb5
1 parent 85036d5
commit 3342bb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/change_notes/2024-12-17-fix-fp-824-a15-4-4 b/change_notes/2024-12-17-fix-fp-824-a15-4-4
@@ -0,0 +1,2 @@
+ - `A15-4-4` - `MissingNoExcept.ql`:
+   - Reduce false positives by not reporting on functions that have a noexcept specification with a complex expression.
diff --git a/cpp/autosar/src/rules/A15-4-4/MissingNoExcept.ql b/cpp/autosar/src/rules/A15-4-4/MissingNoExcept.ql
@@ -28,6 +28,9 @@ where
   not isNoExceptTrue(f) and
   // Not explicitly marked noexcept(false)
   not isNoExceptExplicitlyFalse(f) and
+  // Not having a noexcept specification that
+  // could not be computed as true or false above.
+  not exists(f.getADeclarationEntry().getNoExceptExpr()) and
   // Not compiler generated
   not f.isCompilerGenerated() and
   // The function is defined in this database
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- `A15-4-4` - `MissingNoExcept.ql`:
		- Reduce false positives by not reporting on functions that have a noexcept specification with a complex expression.