Skip to content

Commit

Permalink
DELIA-66976 : SystemAudioPlayer interface
Browse files Browse the repository at this point in the history
Reason for change: Move interface into ThunderInterfaces.
This interface and auto generated ProxyStubs were committed in
rdkcentral/rdkservices. Modifications broke the format
(no trailing nullptr) causing Undefined Behavior.
This impedes use of AddressSanitizer due to SIGSEGV.
Test Procedure: None
Risks: None
Signed-off-by: Nikita Poltorapavlo <npoltorapavlo@productengine.com>
  • Loading branch information
npoltorapavlo committed Dec 24, 2024
1 parent efbfa5b commit 20cbf70
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 0 deletions.
59 changes: 59 additions & 0 deletions interfaces/ISystemAudioPlayer.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:
*
* Copyright 2023 RDK Management
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#pragma once

#include "Module.h"

namespace Thunder {
namespace Exchange {

struct EXTERNAL ISystemAudioPlayer : virtual public Core::IUnknown {
enum { ID = ID_SYSTEMAUDIOPLAYER };

struct INotification : virtual public Core::IUnknown {
enum { ID = ID_SYSTEMAUDIOPLAYER_NOTIFICATION };

virtual ~INotification() {}
virtual void OnSAPEvents(const string &data) = 0;
};

virtual ~ISystemAudioPlayer() {}

virtual uint32_t Configure(PluginHost::IShell* service) = 0;
virtual void Register(INotification* sink) = 0;
virtual void Unregister(INotification* sink) = 0;

virtual uint32_t Open(const string &input, string &output /* @out */) = 0;
virtual uint32_t Play(const string &input, string &output /* @out */) = 0;
virtual uint32_t PlayBuffer(const string &input, string &output /* @out */) = 0;
virtual uint32_t Pause(const string &input, string &output /* @out */) = 0;
virtual uint32_t Resume(const string &input, string &output /* @out */) = 0;
virtual uint32_t Stop(const string &input, string &output /* @out */) = 0;
virtual uint32_t Close(const string &input, string &output /* @out */) = 0;
virtual uint32_t SetMixerLevels(const string &input, string &output /* @out */) = 0;
virtual uint32_t SetSmartVolControl(const string &input, string &output /* @out */) = 0;
virtual uint32_t IsPlaying(const string &input, string &output /* @out */) = 0;
virtual uint32_t Config(const string &input, string &output /* @out */) = 0;
virtual uint32_t GetPlayerSessionId(const string &input, string &output /* @out */) = 0;

};

} // Exchange
} // Thunder
2 changes: 2 additions & 0 deletions interfaces/Ids.h
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ namespace Exchange {
ID_WATERMARK = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x510,
ID_WATERMARK_NOTIFICATION = ID_WATERMARK + 2,

ID_SYSTEMAUDIOPLAYER = RPC::IDS::ID_EXTERNAL_INTERFACE_OFFSET + 0x520,
ID_SYSTEMAUDIOPLAYER_NOTIFICATION = ID_SYSTEMAUDIOPLAYER + 1,
};
}
}

0 comments on commit 20cbf70

Please sign in to comment.