RDK-45037 : Secure Storage Thunder Plugin

[npoltorapavlo]

Reason for change: Enhancements to PersistentStore plugin to support Scope, Time To Live.
Use of the RPC COM and JSON RPC interfaces.
Test Procedure: None
Risks: None
Signed-off-by: Nikita Poltorapavlo npoltorapavlo@productengine.com

[anand-ky]

@MFransen69 - Pls review. We are extending IStore interface used by PersistentStore plugin. Details on requirements are provided under RDK-45037.

[pwielders]

I am making assumptions as I do not have any use-cases but there are definitely some conflicting methods in the interface.
The Key returns its scope (IStore2::GetValue(const string& ns, const string& key, const ScopeType scope, string& value /* @out /, uint32_t& ttl / @out */) this allows the namespace (lets say /MyNameSpace) to hold different types of scoped keys, however there is also a method on IStoreInspector called GetKeys(const string& ns, const ScopeType scope, RPC::IStringIterator*& keys /* @out */) where a namsespace seems to have a scope that might be different from the keys in there ?
That seems to be contradicting, I guess. Is there some document describing the usecase of this functionality?

[MFransen69]

Although the json files are of course still supported was it perhaps considered to add the json interface to the C++ header file using the meta tags? (e.g. see https://rdkcentral.github.io/Thunder/plugin/interfaces/interfaces/ "Enable JSON-RPC Generation" and here for tags that enable you to influence the generated json rpc interface to make it backward compatible if necessary: https://rdkcentral.github.io/Thunder/plugin/interfaces/tags/)

Again the json file is fine but perhaps it is goof to be aware it is also possible to define the com rpc and json rpc interface in one file (and therefore guarantee they are consistent and kept in sync). If there were features missing that made it impossible to use the above please let us know, we are always happy to learn about it and see if we can extend the support for this.

[anand-ky]

@npoltorapavlo - Pls check and respond here. If it's lot of work we can merge these changes now and make subsequent changes to move to using the meta tags.

[npoltorapavlo]

@pwielders I'm not sure I understand the contradiction, can you explain please?

[anand-ky]

@pwielders - Requirements for the Thunder Plugin are detailed at https://etwiki.sys.comcast.net/pages/viewpage.action?spaceKey=RDKV&title=Secure+Store+Enhancements+to+PersistentStore+Plugin
Overall requirements are at https://www.stb.bskyb.com/confluence/pages/viewpage.action?spaceKey=2016&title=Secure+Storage+in+Thunder+HLA#SecureStorageinThunderHLA

[anand-ky]

Changes to keep the enum common and move ScopeType as the first parameter are addressed. We will keep PersistentStore.json for now and add tags to IStore2.h later to generate json from the header.

[MFransen69]

We discussed the semantics of the interface and a few alternatives but seen the promised delivery date and already internally agreed interface it was decided to go ahead and use an IStore2 next to the IStore.