Deployment II #114
Open
Deployment II #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into order_bot
added database documentation the table schemas could be synced a better way
CONTRIBUTE.md
Outdated
| This sections explains how bug triaging is done for your project. Help beginners by including examples to good bug reports and providing them questions they should look to answer. | ||
|
|
||
| * You can help report bugs by filing them here: | ||
| * You can look through the existing bugs here: |
There was a problem hiding this comment.
Where can bugs be reported? And where are they tracked?
you don't need the timestamp because there isn't a column for it in the database
there isn't a column for timestamp for this table in the database
using findAll because you want to be able to find all of the items of that kind
you have to specify you want to pass through the dataValues from the returned db object
…into db_create
modified the units model and the unit route you need to pass through the dataValues instead of the entire response object since there is a bunch of extra stuff you don't need
…into db_create
trichh
requested review from
jamesalexanderdickerson
and removed request for
jamesalexanderdickerson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.