-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ 303ecae3 #735
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luna Wei <luwe@fb.com>
React attends this conference hosted by Callstack. It's been on the page in previous years, missed it this year. https://www.react-native.eu/
…g conferences (#6246) * update conferences to move react rally to previous and add reactjs day * Add React Alicante * Update conferences.md * Update conferences.md to include year of the event * add anchor link * Update conferences.md * Update conferences.md * chore: update country name --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
Grammar fix
Added RenderATL 2024 to the conferences Markdown page
Update Twitter(X) icon for light and dark mode
While reading the new typescript docs introduced in #6120, I noticed this link points to a fork. This commit changes it to a relative link so it should work everywhere.
Fix incorrect link in select.md
Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Luna Wei <luwe@fb.com> Co-authored-by: Ricky Hanlon <rickhanlonii@gmail.com>
React.lazy dots into the `default` property. Document this.
* [WIP] Add use hook API reference page * [WIP] Update use hook API reference page based on feedback * [WIP] use hook API ref doc: add browser API example * [WIP] use hook API ref doc: add context, lib examples * [WIP] use reference doc - incorporate all current feedback * [WIP] use reference page fix typos * use reference doc: address PR feedback from Luna, Sophia,Eli, and Lee * Apply @harish-sethuraman's typo fixes from code review Co-authored-by: Strek <ssharishkumar@gmail.com> * use reference doc typo fixes * use reference doc: update style to match other react.dev conventions * minor fixes * Remove client Promises, use canary labels * Add use hook section to index, remove RSC section on components page * Final edits * Clarify use reference caveats --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
* Update 17 files * remove: legacy react devtool * Update 3 files * fix(editor): allow horizontal scroll * Update SandpackRoot.tsx
corrected links
…llback doesn't seem to be accurate. (#6207) * Update useEffect.md * Update src/content/reference/react/useEffect.md --------- Co-authored-by: Sophie Alpert <git@sophiebits.com>
* delete unused useState import * add word to equalize challenge and solutions texts * Refactor some texts * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <git@sophiebits.com>
Summary of changes: "Server Action", like "Effect", is a React-specific notion that would be benefited from captailization to be distinguished from its genertic meaning. It seems like [Next doc](https://nextjs.org/docs/app/api-reference/functions/server-actions) has also adopted such connventions and we should probably do the same. Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Summary of changes: following <reactjs/react.dev#6417> Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Co-authored-by: Luna Wei <luwe@fb.com>
Summary of changes: See <reactjs/react.dev#6417>. There is one exception though. The error message “Rendered fewer hooks than expected” from React is indeed "hooks" so I kept as-is. Shall we change the error message from React? Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Summary of changes: See <reactjs/react.dev#6417> Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
…(#6445) * Fix: component not returned * Fix: missing function statement
Summary of changes: There is one "TypeScript strict mode" that is kept unchanged. Co-authored-by: xuan.huang <xuan.huang@bytedance.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
this way "cannot be marked" is all the same style and you don't skim the link text and gloss over the "cannot be"
* fix(sandpack-template): use custom react sandpack template * refactor: Remove console.log statement Remove console.log(filePath); from createFileMap.ts * style: Update file paths in Sandpack components Update file paths in Sandpack components to use root folder and variables
* feat: add react india 2024 * update: move react india 2024 in date order * update: move conferences to past section * refactor: sort past conferences
…6496) * specify which sandbox files go in src directory * fix some stragglers
jhonmike
added
duplicate
This issue or pull request already exists
🤖 upstream update
Doc has changed in the upstream repo
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
duplicate
This issue or pull request already exists
🤖 upstream update
Doc has changed in the upstream repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 303ecae
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.