Experiment Concurrent Pools in HTTP/2 Connection Pool #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderop
force-pushed
the
workstealing-pool
branch
from
88ced6e to
02da866
Compare
|
Updated the PR, work still in progress. |
pderop
force-pushed
the
workstealing-pool
branch
from
02da866 to
93cbff3
Compare
|
rebased on top of latest reactor-netty version in order to pick up #3030 |
|
Rebased with latest main branch. |
|
rebased on top of latest main. |
pderop
force-pushed
the
workstealing-pool
branch
from
ea96619 to
a048f99
Compare
|
maybe this draft PR will be removed at some point. in the meantime, just rebased this PR on top of latest branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR experiments the concurrent pools feature (work in progress) from reactor/reactor-pool#179 applied to Reactor Netty HTTP/2 Connection Pool.
For the moment,
workStealingmode can only be configured for HTTP/2 HttpClient via a newenableWorkStealingmethod added in Http2AllocationStrategy interface.So, basically, when an HttpClient is configured with work stealing mode, sub pools (Http2Pool instances) will be created and assigned to each HttpClient's Event Loops, and HTTP2 Connection acquisition tasks will be distributed across all sub pools.
This benchmarks projects can be used to experiment the new client. See the README for the details.
This work is still in progress. Ideally, this PR could be merged into a temporary reactor-netty branch for easier finalization. To be confirmed by the Reactor Netty team.