-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change implementation of bson::Bson #7348
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on change notification after the subscription has already failed (#7304) * Added test for wait for download prior to wait to subs complete * Added some comments and cleaned up code * Updates after cause of failure was discovered * Added changelog entry - updates from review * Merged new test with the existing test for non-queryable field test
* Update OpenSSL dependency * workaround for new SSL_CTX_set_default_verify_paths() behavior * Only use REALM_USE_SYSTEM_OPENSSL_PATHS in the OpenSSL code paths * changelog
`std::aligned_*` is deprecated as of C++23 because the types don't actually work and are prone to UB. Manually using aligned std::byte arrays is the recommended replacement.
Fix problems when building with Xcode 15.3
Some tests triggered background work without waiting for it to complete, resulting in a race condition when tearing down.
Fix a race condition in audit tests
Assorted sync metadata storage refactoring
* fix == NONE {x} queries * more tests
… REALM_ASSERTs (#7338)
Checking if the destination exists before copying is a race condition as the file can be created in between the check and the copy. Instead we should attempt to copy without overwriting the target if it exists.
File a minor race condition in the backup realm file action
Co-authored-by: James Stone <james.stone@mongodb.com>
jedelbo
force-pushed
the
je/bson-impl
branch
5 times, most recently
from
February 19, 2024 13:08
db58d39
to
de9551d
Compare
Begin decoupling sync tests from App
Include paths for the tests are set up slightly different for the SPM build from the CMake build.
"Feature/bugfix release"
Merge next-major
Merge Release/14.0.0
jedelbo
force-pushed
the
je/bson-impl
branch
from
February 26, 2024 10:32
de9551d
to
3f329e7
Compare
The new implementation will store the content in Bson format according to the specification. In this way it will be easy to export realm data in that format.
Having a binary field in a BsonDocument should store and return the original binary data and not the base64 encoded data.
jedelbo
force-pushed
the
je/bson-impl
branch
from
February 26, 2024 12:17
3f329e7
to
d6934d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation will store the content in Bson format according to the specification. In this way it will be easy to export realm data in that format. Performance is also somewhat better.
What, How & Why?
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed