Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation of bson::Bson #7348

Closed
wants to merge 48 commits into from
Closed

Change implementation of bson::Bson #7348

wants to merge 48 commits into from

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 15, 2024

The new implementation will store the content in Bson format according to the specification. In this way it will be easy to export realm data in that format. Performance is also somewhat better.

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Michael Wilkerson-Barker and others added 30 commits February 2, 2024 08:43
…on change notification after the subscription has already failed (#7304)

* Added test for wait for download prior to wait to subs complete
* Added some comments and cleaned up code
* Updates after cause of failure was discovered
* Added changelog entry - updates from review
* Merged new test with the existing test for non-queryable field test
* Update OpenSSL dependency

* workaround for new SSL_CTX_set_default_verify_paths() behavior

* Only use REALM_USE_SYSTEM_OPENSSL_PATHS in the OpenSSL code paths

* changelog
`std::aligned_*` is deprecated as of C++23 because the types don't actually
work and are prone to UB. Manually using aligned std::byte arrays is the
recommended replacement.
Fix problems when building with Xcode 15.3
Some tests triggered background work without waiting for it to complete,
resulting in a race condition when tearing down.
Fix a race condition in audit tests
Assorted sync metadata storage refactoring
* fix == NONE {x} queries

* more tests
Checking if the destination exists before copying is a race condition as the
file can be created in between the check and the copy. Instead we should
attempt to copy without overwriting the target if it exists.
File a minor race condition in the backup realm file action
@jedelbo jedelbo force-pushed the je/bson-impl branch 5 times, most recently from db58d39 to de9551d Compare February 19, 2024 13:08
@jedelbo jedelbo marked this pull request as ready for review February 19, 2024 14:36
@jedelbo jedelbo changed the base branch from next-major to bson-reform February 21, 2024 10:29
The new implementation will store the content in Bson
format according to the specification. In this way it will
be easy to export realm data in that format.
Having a binary field in a BsonDocument should store and return  the original
binary data and not the base64 encoded data.
@jedelbo jedelbo marked this pull request as draft February 27, 2024 09:37
@jedelbo jedelbo closed this Feb 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants