Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new builder with compression always enabled for verifying correctness #7524

Conversation

nicola-cab
Copy link
Member

What, How & Why?

Compressing integer arrays will basically impact all the data stored and queried in these arrays. Adding a new builder that runs with compression always on in order to verify that none of our tests breaks when the storing format changes.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good!

Copy link

Pull Request Test Coverage Report for Build nicola.cabiddu_1558

Details

  • 20 of 24 (83.33%) changed or added relevant lines in 2 files are covered.
  • 42 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.598%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/array_encode.cpp 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 93.68%
test/test_dictionary.cpp 1 99.85%
test/test_sync.cpp 1 94.36%
src/realm/collection_parent.cpp 2 92.48%
src/realm/query_expression.hpp 2 93.68%
src/realm/sync/network/http.hpp 2 82.41%
src/realm/sync/network/network.cpp 3 89.66%
src/realm/util/file.cpp 3 81.02%
src/realm/util/future.hpp 3 95.98%
src/realm/sync/transform.cpp 4 64.67%
Totals Coverage Status
Change from base Build nicola.cabiddu_1554: 0.03%
Covered Lines: 245063
Relevant Lines: 267543

💛 - Coveralls

@nicola-cab nicola-cab force-pushed the nc/add_builder_for_verify_int_compression_for_all_arrays branch from 29df2c4 to 43a487e Compare March 26, 2024 16:34
@nicola-cab nicola-cab merged commit 83ea235 into nc/merge_all_together Mar 26, 2024
6 of 17 checks passed
@nicola-cab nicola-cab deleted the nc/add_builder_for_verify_int_compression_for_all_arrays branch March 26, 2024 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants