Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-2134 fix output syntax #7763

Merged
merged 2 commits into from
May 31, 2024
Merged

RCORE-2134 fix output syntax #7763

merged 2 commits into from
May 31, 2024

Conversation

ironage
Copy link
Contributor

@ironage ironage commented May 31, 2024

#7730 added a summary, but the syntax didn't work: https://github.com/realm/realm-core/actions/runs/9323985651/workflow

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@ironage ironage self-assigned this May 31, 2024
@cla-bot cla-bot bot added the cla: yes label May 31, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build james.stone_554

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.05%) to 90.865%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/instructions.hpp 1 76.03%
src/realm/sync/noinst/server/server.cpp 1 74.0%
src/realm/uuid.cpp 1 98.48%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
src/realm/cluster.cpp 2 75.6%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/transform.cpp 2 60.99%
test/fuzz_group.cpp 2 52.47%
src/realm/sync/noinst/protocol_codec.hpp 3 74.03%
Totals Coverage Status
Change from base Build 2366: 0.05%
Covered Lines: 214667
Relevant Lines: 236248
💛 - Coveralls

nielsenko
nielsenko approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ironage ironage merged commit 0a1fce3 into master May 31, 2024
43 of 45 checks passed
@ironage ironage deleted the js/fix-gha-syntax branch May 31, 2024 22:45
@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

Assignees

@ironage ironage

Labels
cla: yes no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ironage @nielsenko