-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Realm Kotlin 2.0.0 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 great!
// For some reason libsx.plugins.realm does not resolve directly so go through the provider | ||
id(libsx.plugins.realm.get().pluginId) | ||
// For some reason this does not resolve even though [id: 'org.jetbrains.kotlin.native.cocoapods', version: '2.0.0'] is available in Gradle plugin portal | ||
// alias(libsx.plugins.cocoapods) | ||
kotlin("native.cocoapods") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be added to the versions catalog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The comment above states why.
Bookshelf/shared/build.gradle.kts
Outdated
@@ -39,7 +42,7 @@ kotlin { | |||
implementation("io.ktor:ktor-client-content-negotiation:$ktorVersion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be added to the catalog too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main idea with doing the catalog was to make it easy to bump the major components (Kotlin, AGP, Realm, etc.) across all samples in the repository. I have added these to the catalogs know, but there are still an awful lot of dependencies and constants that are not in the catalog. We can address these along the way when we have to bump them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Bookshelf/shared/build.gradle.kts
Outdated
alias(libsx.plugins.kotlinMultiplatform) | ||
alias(libsx.plugins.androidLibrary) | ||
alias(libsx.plugins.kotlinSerialization) | ||
// For some reason libsx.plugins.realm does not resolve directly so go through the provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because you were using snapshot and it was not published on Gradle portal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It cannot verify the version when the plugin is already on the classpath. I could remote the classpath
entry now that we have a released version, but a bit tedious if we want to do back and forth between snapshot/non-snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it as is to ease working with snapshots, but added a comment.
No description provided.