Improve tests using Channels #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 15:55
…sert if containing elements when the channel is closed. Add an unlimited buffer to our test channel, so we do not accidentially overwrite events.
|
This PR is now ready for review |
nhachicha
approved these changes
Dec 7, 2023
packages/test-base/src/commonMain/kotlin/io/realm/kotlin/test/util/Utils.kt
Outdated
Show resolved
Hide resolved
...e/src/commonTest/kotlin/io/realm/kotlin/test/common/notifications/RealmNotificationsTests.kt
Show resolved
Hide resolved
...ages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SyncedRealmTests.kt
Outdated
Show resolved
Hide resolved
| val job = async { | ||
| realm.query<ObjectIdPk>("_id = $0", BsonObjectId(oid)).first() | ||
| .asFlow().collect { | ||
| if (it.obj != null) { | ||
| channel.trySend(it.obj!!) | ||
| channel.send(it.obj!!) |
There was a problem hiding this comment.
Why not use trySendOrFail?
Co-authored-by: Nabil Hachicha <nabil.hachicha@mongodb.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines how we are using Channels in tests by introducing a new TestChannel factory method which will ensure we construct the same channel across all tests.
This channel has a few changes compared to the previous one:
sendshould never suspend and we should never accidentally overwrite an event.I also refactored
Channel.receiveOrFail(),onReceivein channels does not consume elements and we suspect it might be the cause of some of our flaky tests (but hasn't been 100% confirmed).All uses of
trySend()in tests has also been replaced bysend()sincetrySend()might fail silently causing us to miss an error.