Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sbt for sarplus tests #2192

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

SimonYansenZhao
Copy link
Collaborator

Description

This PR installs sbt in the testing workflow of sarplus, because GitHub hosted runner ubuntu-24.04 removed the installation of sbt, making the tests for sarplus fail.

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SimonYansenZhao SimonYansenZhao merged commit 53b5d53 into staging Dec 2, 2024
8 checks passed
@SimonYansenZhao SimonYansenZhao deleted the simonz/sarplus-sbt branch December 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants