ci: initial Packit configuration #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `/run/motd.d` to the hardcoded MOTD_FILE Addresses: coreos/console-login-helper-messages#60
Let's make upstream tests more stable to be usable in RHEL environment where we do not use ASAN and meson. Upstream: http://github.com/karelzak/util-linux/commit/331c5e0c54d9cb6f67dc3e825eec2d78c67d8ce6 Signed-off-by: Karel Zak <kzak@redhat.com>
Upstream: http://github.com/karelzak/util-linux/commit/85ae61dd6d956e7c9fe2b22b8c46bb1d0bfd13da Signed-off-by: Karel Zak <kzak@redhat.com>
Upstream: http://github.com/karelzak/util-linux/commit/abe16d0d34413555fbd621f90a0b93c2105116a2 Signed-off-by: Karel Zak <kzak@redhat.com>
mrc0mmand
force-pushed
the
packit-onboard
branch
9 times, most recently
from
ff73561 to
da8d2b4
Compare
mrc0mmand
force-pushed
the
packit-onboard
branch
5 times, most recently
from
5f78e19 to
9153d05
Compare
Enable a basic set of Packit jobs to build util-linux RPMs from a RHEL9/C9S specfile - on F34 for now, until we have public C9S images available in Copr. Some comments to the sed magic in the yaml configuration file: 1) We have to create a custom tarball by our own means, since the default Packit action doesn't include the necessary .tarball-version file. This wouldn't be necessary if we could use the `make distcheck` target, but the default builder chroot is missing some dependencies (like bison), so we have to fallback to `git archive`. 2) Consequently, we need to call autogen.sh from the specfile (normally we'd call it before `make distcheck` and already have a configure binary in the tarball) 3) Also consequently, explicitly run the `check` RPM phase during rpmbuild (by setting `_with_check 1`). This would be, also, normally executed by `make distcheck`. As requested, run the checks on push events into the rhel-9 branch instead of for each pull request. This workflow can be later extended to send the built RPMs to the Testing Farm (TFT)[0] for a more extensive testing. [0] https://packit.dev/docs/testing-farm/
mrc0mmand
force-pushed
the
packit-onboard
branch
from
9153d05 to
e66cdb9
Compare
jamacku
reviewed
Feb 3, 2022
| metadata: | ||
| branch: rhel-9 | ||
| targets: | ||
| # FIXME: change to CentOS 9 once it's available |
There was a problem hiding this comment.
CentOS 9 targets are now available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a basic set of Packit jobs to build util-linux RPMs from a
RHEL9/C9S specfile - on F34 for now, until we have public C9S images
available in Copr.
Some comments to the sed magic in the yaml configuration file:
We have to create a custom tarball by our own means, since the
default Packit action doesn't include the necessary .tarball-version
file. This wouldn't be necessary if we could use the
make distchecktarget, but the default builder chroot is missing some dependencies
(like bison), so we have to fallback to
git archive.Consequently, we need to call autogen.sh from the specfile (normally
we'd call it before
make distcheckand already have a configurebinary in the tarball)
Also consequently, explicitly run the
checkRPM phase duringrpmbuild (by setting
_with_check 1). This would be, also, normallyexecuted by
make distcheck.As requested, run the checks on push events into the rhel-9 branch
instead of for each pull request.
This workflow can be later extended to send the built RPMs to the
Testing Farm (TFT)[0] for a more extensive testing.
[0] https://packit.dev/docs/testing-farm/