[feature] DRY-refactor chakra UI theme extension and implement typescript file generation #11872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philzen
changed the title
Philzen
changed the title
|
@Tobbe This is ready for review. But i'm pretty confused though looking at the test failure in the jobs package: https://cloud.nx.app/runs/B3Di6rkdxZ/task/%40redwoodjs%2Fjobs%3Atest as this PR doesn't touch that area 🤔 Will update the last commit's hash to trigger another run in order to confirm whether that is a flaky test or persists. |
Philzen
force-pushed
the
refactor/centralize-chakra-ui-theme-extension-and-allow-typescript
branch
from
84d5f21 to
f70c86d
Compare
…n-and-allow-typescript
Unfortunately that one is a little bit flaky :/ |
Things like that happen 🤷 Made us a quick reminder to look at that at times and to document that we're currently aware of this issue: #11873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
extendTheme()call in the theme config file – reducing duplication inApp.tsxand.storybook/preview.*