New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Receiver #442

Merged

raoulvdberge merged 2 commits into develop from feature/GH-96/network-receiver

Oct 31, 2023

Contributor

raoulvdberge commented Oct 31, 2023

Fixes #96


          feat: network receiver

07e5445

raoulvdberge force-pushed the feature/GH-96/network-receiver branch 3 times, most recently from 5aa42de to e900955 Compare

October 31, 2023 19:58


          refactor: class hierarchy of network node containers

456a3cf

Introduced NetworkNodeContainerBlockEntityImpl, that inherits from the API block entity. It only has
 code for activeness checking.

Modified AbstractInternalNetworkNodeContainerBlockEntity to have redstone mode, placed by and
 configuration card code.

Modified cable and network receiver to inherit from NetworkNodeContainerBlockEntityImpl
since they don't need redstone mode
and especially not configuration card support.

raoulvdberge force-pushed the feature/GH-96/network-receiver branch from e900955 to 456a3cf Compare

October 31, 2023 20:36

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

raoulvdberge merged commit ed5652d into develop

7 checks passed

raoulvdberge deleted the feature/GH-96/network-receiver branch

October 31, 2023 20:48

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet