-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying ipv6 addresses #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Looks mostly good. Also I fixed CI upstream. Could you rebase and process the suggestions?
Hi, can this be merged? Would appreciate ipv6 support, thanks! |
Sure! Could you rebase this, process the feedback, and provide a new PR? Ideally could you also verify this works? I’m inclined to believe it does, but I can’t test it myself. |
Sorry for long radio silence, I forgot I had this PR for a while. I address the comments and cleaned up a bit further. Hope you liked it better now. Unfortunately my ISP decided not to give me an IPv6 address these days. Any help is appreciated to test if this works. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 94.11% 95.34% +1.23%
==========================================
Files 1 1
Lines 34 43 +9
Branches 7 8 +1
==========================================
+ Hits 32 41 +9
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Could you fix CI? I tried, but I’m not allowed to push to your fork. |
Released in version 3.1.0 🎉 |
If your ISP supports ipv6 like mine, chances are you are already getting a persistent address already without having to pay for a static ipv4 address. This commit enables us to send magic packets to ipv6 targets.