Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying ipv6 addresses #26

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

alimg
Copy link
Contributor

@alimg alimg commented Jul 2, 2022

If your ISP supports ipv6 like mine, chances are you are already getting a persistent address already without having to pay for a static ipv4 address. This commit enables us to send magic packets to ipv6 targets.

Copy link
Owner

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Looks mostly good. Also I fixed CI upstream. Could you rebase and process the suggestions?

wakeonlan.py Outdated Show resolved Hide resolved
wakeonlan.py Outdated Show resolved Hide resolved
@infalmo
Copy link

infalmo commented Nov 12, 2023

Hi, can this be merged? Would appreciate ipv6 support, thanks!

@remcohaszing
Copy link
Owner

Sure! Could you rebase this, process the feedback, and provide a new PR?

Ideally could you also verify this works? I’m inclined to believe it does, but I can’t test it myself.

@alimg
Copy link
Contributor Author

alimg commented Nov 15, 2023

Sorry for long radio silence, I forgot I had this PR for a while. I address the comments and cleaned up a bit further. Hope you liked it better now.

Unfortunately my ISP decided not to give me an IPv6 address these days. Any help is appreciated to test if this works.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa98922) 94.11% compared to head (f583983) 95.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   94.11%   95.34%   +1.23%     
==========================================
  Files           1        1              
  Lines          34       43       +9     
  Branches        7        8       +1     
==========================================
+ Hits           32       41       +9     
  Misses          1        1              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcohaszing
Copy link
Owner

Could you fix CI? I tried, but I’m not allowed to push to your fork.

@remcohaszing remcohaszing merged commit 1a006fc into remcohaszing:main Nov 17, 2023
11 checks passed
@remcohaszing
Copy link
Owner

Released in version 3.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants