Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw single fetch redirects fetched from the server #10317

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Throw single fetch redirects fetched from the server #10317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-melons-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/react": patch
---

Throw unwrapped single fetch redirect to align with pre-single fetch behavior
2 changes: 1 addition & 1 deletion packages/remix-react/single-fetch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ function unwrapSingleFetchResult(result: SingleFetchResult, routeId: string) {
if (result.replace) {
headers["X-Remix-Replace"] = "yes";
}
return redirect(result.redirect, { status: result.status, headers });
throw redirect(result.redirect, { status: result.status, headers });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/remix-run/remix/blob/main/packages/remix-react/routes.tsx#L588

} else if ("data" in result) {
return result.data;
} else {
Expand Down
Loading