RELEASE: fix single fetch generic as cast (again) #9957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two checks to ensure that the generic type was a function. For back compat, we need to allow non-function types, but #9948 only removed one of the checks. This removes the other check.
Type tests didn't catch this as we only check single-fetch types assuming the outer checks that rely on interface merging pass. We can't test the whole
SerializeFrom
type with interface merging in our repo as that will override types in the entire repo to be single-fetch aware.