Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sharedVariableName #33111

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: sharedVariableName #33111

wants to merge 4 commits into from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 14, 2024

Changes

Replaces groupName in manager extract results with sharedVariableName instead. I chose to keep groupName later for simplicity and backwards compatibility.

Context

We should still group updates if they have shared variables, but separate the concept from manually-configured groupNames.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 14, 2024

Needs testing on at least one real repo

@rarkins rarkins requested a review from Churro December 14, 2024 10:01
@rarkins rarkins marked this pull request as draft December 14, 2024 10:01
@rarkins
Copy link
Collaborator Author

rarkins commented Dec 14, 2024

FYI I want to have a similar concept for monorepoName after this

lib/workers/repository/updates/branch-name.ts Outdated Show resolved Hide resolved
lib/workers/types.ts Outdated Show resolved Hide resolved
rarkins and others added 2 commits December 14, 2024 11:33
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins rarkins marked this pull request as ready for review December 18, 2024 09:47
@rarkins rarkins requested a review from secustor December 18, 2024 09:47
@rarkins
Copy link
Collaborator Author

rarkins commented Dec 18, 2024

I think let's wait until the new year to merge this one, as it could be disruptive if wrong

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 20, 2024

Let's merge this after Jan 6

@rarkins rarkins marked this pull request as draft December 20, 2024 12:53
@rarkins
Copy link
Collaborator Author

rarkins commented Dec 20, 2024

@zharinov could you look for at least one "real" repo to test against? You might still have the ones you tested against back when you added support for variables

Copy link
Collaborator

@Churro Churro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Churro
Copy link
Collaborator

Churro commented Dec 20, 2024

Unrelated to this change but I think this no longer needed:

depGroup?: string;

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 20, 2024

Unrelated to this change but I think this no longer needed:

depGroup?: string;

I'd forgotten about this, but this was an earlier attempt I made to fix the same problem

@zharinov
Copy link
Collaborator

@zharinov could you look for at least one "real" repo to test against? You might still have the ones you tested against back when you added support for variables

Just updated this one: https://github.com/renovate-testing/test-10436-lein-vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants