-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sharedVariableName #33111
base: main
Are you sure you want to change the base?
feat: sharedVariableName #33111
Conversation
Needs testing on at least one real repo |
FYI I want to have a similar concept for |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add docs to https://github.com/renovatebot/renovate/blob/main/docs%2Fdevelopment%2Fadding-a-package-manager.md too
I think let's wait until the new year to merge this one, as it could be disruptive if wrong |
Let's merge this after Jan 6 |
@zharinov could you look for at least one "real" repo to test against? You might still have the ones you tested against back when you added support for variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully for gradle using randomly picked old reproduction repos that use variables:
Unrelated to this change but I think this no longer needed: renovate/lib/modules/manager/types.ts Line 170 in c47224e
|
I'd forgotten about this, but this was an earlier attempt I made to fix the same problem |
Just updated this one: https://github.com/renovate-testing/test-10436-lein-vars |
Changes
Replaces
groupName
in manager extract results withsharedVariableName
instead. I chose to keepgroupName
later for simplicity and backwards compatibility.Context
We should still group updates if they have shared variables, but separate the concept from manually-configured groupNames.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: