-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config/toml): support jinja templates in toml files #33123
base: main
Are you sure you want to change the base?
Conversation
Following the specification in https://jinja.palletsprojects.com/en/stable/templates/#synopsis, there are three types of delimiters: 1. Statements 2. Expressions 3. Comments
fa5430b
to
0099a48
Compare
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
@viceice I've added tests for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please inline the fixtures as part of the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're currently not merging features because all maintainer are in Christmas holiday and we don't want to break anything now.
Thanks for letting me know. Have a wonderful holiday! |
Changes
removeTemplate
option to theparseToml
functionremoveTemplate: true
config topoetry
andpep621
pyproject.toml
parsers.Context
This addresses the feature request raised in #33105 by applying a similar method in the
yaml
parser in #26682.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: