feat(datasource/unity3d): Use Unity Releases API #33240
Open
+195
−312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Dec 22, 2024
| @@ -0,0 +1,14 @@ | |||
| export interface UnityReleasesJSON { | |||
| Unity3dDatasource.streams.stable, | ||
| Unity3dDatasource.streams.lts, | ||
| ]; | ||
| override readonly defaultRegistryUrls = [Unity3dDatasource.streams.lts]; | ||
|
|
||
| override readonly defaultVersioning = Unity3dVersioning.id; |
There was a problem hiding this comment.
release timestamp message below needs an update
| static readonly homepage = 'https://unity.com/'; | ||
| static readonly streams: Record<string, string> = { | ||
| lts: `${Unity3dDatasource.homepage}releases/editor/lts-releases.xml`, |
There was a problem hiding this comment.
we need a compatibility helper which translates old registry urls to the new API urls. otherwise this is a breaking change.
another option is to check passed registry url and use old RSS API when an old url is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The API has been changed to use the new Unity Releases API instead of the "old RSS system".
The new API is richer in metadata, allows more granularity by having queries (number of results, stream, os, architecture, version, ...). Example: https://services.api.unity.com/unity/editor/release/v1/releases?stream=LTS&platform=WINDOWS&architecture=X86_64
I have removed many tests that no longer make sense and were there before because of the inconsistencies of the RSS system. This new API has filters and these inconsistencies no longer occur.
I have also aligned the Unity terminology of streams (lts, tech, alpha, beta).
Context
Unity Releases API: https://services.docs.unity.com/release/v1/#tag/Release/operation/getUnityReleases
Example call: https://services.api.unity.com/unity/editor/release/v1/releases?stream=LTS
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: