Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mix): add depType support #33310

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sheerlox
Copy link
Contributor

@sheerlox sheerlox commented Dec 27, 2024

Changes

Adds support for depType based on the only Mix dependency option.

Context

I'm using Conventional Commits & Semantic Release for my Elixir projects. Not having depType available means I have to choose between always releasing (build(deps):) or never releasing (chore(deps):) dependency updates.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@sheerlox sheerlox force-pushed the feat/manager-mix-add-depType branch from b8a6975 to 2d1fdac Compare December 28, 2024 02:14
@sheerlox sheerlox marked this pull request as ready for review December 28, 2024 02:14
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you're reusing the npm terms "dependencies" and "devDependencies" but that's not necessary. Probably more intuitive for mix users if they are like "prod" and "dev"?

@sheerlox sheerlox requested a review from rarkins December 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants