-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call out to fio
for host filesystem performance
#1275
call out to fio
for host filesystem performance
#1275
Conversation
fio
for host filesystem performance
can we get a description in the PR for what this is doing exactly, and fix up the merge conflicts? I'm hoping that'll trigger the tests to run. We are going to need to get some testing into this PR to be able to approve it. I like the approach, makes sense to me and will produce much more accurate results. |
7fa54be
to
817bf74
Compare
ok, tests should finally run, fixed up go.mod problems, @xavpaice ack on the test coverage |
added some code to handle permission errors gracefully:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I ran some tests using both preflight
and support-bundle
binaries.
I made a few minor comments to improve the code
mm tests are failing, have to fix something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall. I added a few comments, but nothing that would affect the structure of the PR too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it 🚀
Description, Motivation and Context
Shell out to the
fio
utility to collect filesystem write latency info instead of using the old method of writing to disk directly. Work in some additional types to support using any of the metrics thatfio
returns in future analyzers.#1215
Checklist
Update filesystemPerformance.md for fio binary troubleshoot.sh#519
Does this PR introduce a breaking change?
the collector will require the installation of the
fio
binary. Iffio
is not installed, the collector will fail to run and print an error, similarly to our other collectors that require userspace utilities to be installed.