Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct how configmap and secrets paths are parsed in the CLI #1375

Merged

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Oct 17, 2023

Description, Motivation and Context

When passing a secret/<namespace-name>/<secret-name>/<data-key> or configmap/<namespace-name>/<configmap-name>/<data-key>, the <data-key> part causes both preflight and support-bundle applications to error. This is because the <data-key> part is not expected due to a recent refactoring change.. This PR fixes that

Fixes: #1374

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh added type::bug Something isn't working bug::regression labels Oct 17, 2023
@banjoh banjoh requested a review from a team as a code owner October 17, 2023 14:25
@banjoh banjoh merged commit 42fc4f0 into replicatedhq:main Oct 18, 2023
23 checks passed
@banjoh banjoh deleted the em/fix-configmap-and-secret-path-parsing branch October 18, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--redactors flag fails to parse resources that specify a data key
3 participants