Make dispatchers overriding for DODW publicly available and resettable #41
Conversation
|
|
||
| val delegate = DataObservableDelegateWrapper<Unit, String>( | ||
| fromNetwork = { | ||
| delay(3.seconds) |
There was a problem hiding this comment.
Verifies that delays are actually skipped (in combination with 1s timeout for the whole test)
|
|
||
| DataObservableDelegateWrapperDispatchers.setDispatchers(testDispatcher) | ||
| DataObservableDelegateWrapperDispatchers.IO shouldBe testDispatcher | ||
| DataObservableDelegateWrapperDispatchers.Unconfined shouldBe testDispatcher |
There was a problem hiding this comment.
these are cluttering this test case IMO, if you want to test the setter/getter behaviour better be done separately
| } | ||
| networkDispatcher shouldBe testDispatcher | ||
|
|
||
| DataObservableDelegateWrapperDispatchers.resetDispatchers() |
There was a problem hiding this comment.
same here, just move out set/get/reset assertions in a separate test case
| fun resetDispatchers() { | ||
| IO = Dispatchers.IO | ||
| Unconfined = Dispatchers.Unconfined |
There was a problem hiding this comment.
I'd reuse this method in init phase as well, not repeat IO = Dispatchers.IO / Unconfined = Dispatchers.Unconfined twice
There was a problem hiding this comment.
We'll need to declare the properties as lateinit, otherwise compiler is not satisfied. Do you think it's worth it?
There was a problem hiding this comment.
sounds fair, unless you see any issues with that
DataObservableDelegateWrapperDispatcherswas initially marked as internal because I wasn't sure it's really needed: typical DOD usage was already testable synchronously thanks toDispatchers.UnconfinedinfromNetwork.But recently we hit the case where
fromNetworkcontains internal loop with delays to implement polling. These delays are not skippable without injecting someTestDispatcher.We should also provide the means to reset dispatchers, to keep tests self-contained and independent of each other.