Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jaeger collector #616

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove jaeger collector #616

merged 1 commit into from
Oct 4, 2023

Conversation

philipgough
Copy link
Contributor

This removes the jsonnet and all left over references in favour of using the TempoStack

douglascamata
douglascamata approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jacobbaungard
Copy link
Member

Do we still need services/sidecars/jaeger-agent.libsonnet ?

@philipgough
Copy link
Contributor Author

Do we still need services/sidecars/jaeger-agent.libsonnet ?
yep for now at least

@philipgough philipgough merged commit 3ec83ae into rhobs:main Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbaungard jacobbaungard jacobbaungard approved these changes

@douglascamata douglascamata douglascamata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipgough @jacobbaungard @douglascamata