chore: disable custom config deprecation flag #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add a README that explains the purpose of the repo. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
This commit fixes a small typo in the README.md file and remove blank spaces. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
Fix typo in README
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
chore: update README.md
|
👍 waiting for the PO feature to merge. |
rexagod
commented
Oct 16, 2024
| @@ -31,6 +31,8 @@ patches: | |||
| image: <IMG_PROMETHEUS_OPERATOR> | |||
| args: | |||
| - --prometheus-config-reloader=<IMG_PROMETHEUS_CONFIG_RELOADER> | |||
| # Refer https://github.com/prometheus-operator/prometheus-operator/pull/6955 | |||
| - --deprecate-custom-configuration=false | |||
There was a problem hiding this comment.
Suggested change
| - --deprecate-custom-configuration=false | |
| - -disable-unmanaged-prometheus-configuration |
This commit adds a directory - rhobs to hold all scripts required to create a forked release of Prometheus Operator. It additionally adds a github workflow that is needed to create and publish container images. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
The upgrade tests fails to download the previous stable release VERSION and examples. This commits fixes it by replacing the urls to point to the <gh>/rhobs/obo-prometheus-operator repo. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
The make-release-commit.sh script now accepts a mandatory argument --previous-version that should point to the last stable release The make-release-commit.sh script now validates that the * git remotes are valid * the release branch exists * local git repo is in a clean state before running the script Signed-off-by: Sunil Thaha <sthaha@redhat.com>
I'm not 100% sure on the details but I think the push command `git push downstream v0.60.0:refs/heads/rhobs-rel-0.60.0-rhobs1` will only succeed if the remote branch exists already. So I added a few more steps that should work for more folks out of the box. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Renames ObO Prometheus Operator to RHOBS Prometheus Operator and adds the icon (cherry picked from commit 8db86b1)
Disable the custom config deprecation behavior flag to enable OBO to drop service discovery entirely.
rexagod
force-pushed
the
rhobs-scripts
branch
from
4472246 to
64fcfc7
Compare
|
Continued at #76, this got closed unexpectedly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the custom config deprecation behavior flag to enable OBO to drop service discovery entirely.