-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract more-complex chapters from the pinned comment; select "normal" chapters or comment chapters #21
Open
Lazyt3ch
wants to merge
125
commits into
ris58h:master
Choose a base branch
from
Lazyt3ch:feature1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content.js, background.js
…ns and declarative_net_request in Chrome-specific manifest.json file
…estOriginRemoval function in background.js
…URLS with multiple search params (content.js)
… alignings, etc. (content.css, content.js)
…appear (content.js)
…itle (content.js)
…ground.js, content.js)
….js, content.css)
…ction (background.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ilya,
I've found a case where each comment line can contain either one or more chapters, or no chapters at all: https://www.youtube.com/watch?v=PzlLXQ3RaDs
I've added some code to extract chapters from such comments.
I've also found a case where the chapters provided in the pinned comment are much better than the "key moments" automatically added by YouTube: https://www.youtube.com/watch?v=5Gt61EX6HZ4
In that case, when the extension tries to fetch chapters, it gets the "key moments" instead – and displays them as chapters. Unfortunately, the result makes no sense.
I've made minor changes to the extension, and now, if both the "normal" chapters (that is, either full-fledged chapters or "key moments") and the chapters extracted from the pinned comment are available, it select the more-numerous ones.
Actually, both cases are pretty unusual, so I'm not sure if handling them is worth the effort.
Regards,
Rashid
P.S. I've also added the following functionality: