ZIR-182: Jacob/add examples #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkoo
reviewed
Oct 11, 2024
| @@ -37,6 +37,8 @@ std::string mangledTypeName(StringRef componentName, llvm::ArrayRef<Attribute> t | |||
| llvm::interleaveComma(typeArgs, stream, [&](Attribute typeArg) { | |||
| if (auto strAttr = typeArg.dyn_cast<StringAttr>()) { | |||
| stream << strAttr.getValue(); | |||
| } else if (auto intAttr = typeArg.dyn_cast<IntegerAttr>()) { | |||
There was a problem hiding this comment.
Under what circumstances are we generating an IntegerAttr? Aren't we coercing everything into field elements?
mars-risc0
approved these changes
Oct 30, 2024
| } | ||
|
|
||
| component FullAdder(x: BitReg, y: BitReg, c: BitReg) { | ||
| sum := Xor(Xor(x, y), c); |
There was a problem hiding this comment.
seems like either this line should use Xor3 defined above, or the otherwise-unused Xor3 component ought to be dropped from the example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two examples to the repository: