Fix LCOFI bit implementation in hvip register #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
@NewPaulWalker note that this essentially reverts #1862, but it does appear to be the correct thing to do when AIA is not implemented.
I agree with this statement. I apologize for my previous misunderstanding and appreciate your effort in identifying and resolving this issue. |
|
No prob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the implementation of the LCOFI bit in the hvip register in Spike.
The RISC-V specification states:
According to this description, the LCOFI bit in hvip should only be implemented and writable when all the above extensions (Smcdeleg/Ssccfg, Sscofpmf, Smaia/Ssaia, and the H extension) are implemented.
Spike doesn't support AIA, so for now, this bit shouldn't be implemented at all.
Resolves #1886